Call options.log for structured logs
#3187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3187 +/- ##
==========================================
+ Coverage 87.70% 87.89% +0.18%
==========================================
Files 291 291
Lines 9916 9952 +36
==========================================
+ Hits 8697 8747 +50
+ Misses 1219 1205 -14 ☔ View full report in Codecov by Sentry. |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ec78888 | 1251.37 ms | 1269.40 ms | 18.04 ms |
| 7cfbbd6 | 1270.63 ms | 1285.36 ms | 14.72 ms |
| 793f4dc | 1262.50 ms | 1282.35 ms | 19.85 ms |
| b6c8720 | 1252.65 ms | 1266.61 ms | 13.96 ms |
| 6b69699 | 1254.80 ms | 1273.31 ms | 18.52 ms |
| cc4e375 | 1253.06 ms | 1263.81 ms | 10.75 ms |
| 2d34233 | 1258.19 ms | 1268.92 ms | 10.73 ms |
| 575ebaa | 1262.20 ms | 1274.24 ms | 12.04 ms |
| 32914d8 | 1275.47 ms | 1285.20 ms | 9.73 ms |
| 640ad0c | 1241.04 ms | 1253.96 ms | 12.92 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ec78888 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 7cfbbd6 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 793f4dc | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| b6c8720 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 6b69699 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| cc4e375 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 2d34233 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 575ebaa | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 32914d8 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 640ad0c | 7.86 MiB | 9.44 MiB | 1.58 MiB |
buenaflor
reviewed
Aug 25, 2025
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93b7728 | 475.28 ms | 489.13 ms | 13.86 ms |
| c8596a6 | 474.00 ms | 492.96 ms | 18.96 ms |
| 73a3c38 | 478.18 ms | 526.62 ms | 48.44 ms |
| 0fb45d0 | 482.79 ms | 554.02 ms | 71.23 ms |
| 640ad0c | 466.00 ms | 552.67 ms | 86.67 ms |
| 765aa8b | 493.51 ms | 531.23 ms | 37.72 ms |
| cc4e375 | 426.15 ms | 482.34 ms | 56.19 ms |
| c1e775e | 482.36 ms | 608.98 ms | 126.62 ms |
| 2d34233 | 470.54 ms | 558.90 ms | 88.36 ms |
| 54acf91 | 487.24 ms | 529.60 ms | 42.36 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93b7728 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| c8596a6 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
| 73a3c38 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 0fb45d0 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| 640ad0c | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 765aa8b | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| cc4e375 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| c1e775e | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| 2d34233 | 6.54 MiB | 7.55 MiB | 1.01 MiB |
| 54acf91 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
buenaflor
reviewed
Aug 25, 2025
buenaflor
approved these changes
Aug 26, 2025
Contributor
buenaflor
left a comment
buenaflor
left a comment
There was a problem hiding this comment.
lgtm, did you check that this doesn't double console log for structured logs created by the logging integration?
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
buenaflor
reviewed
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Call
options.logfor structured logs, so users see console output when options.debug is enabled.💡 Motivation and Context
Closes #3124
💚 How did you test it?
Unit tests.
📝 Checklist
sendDefaultPiiis enabled